Add in a parser for vendor SummitIG#395
Open
nsw3550 wants to merge 3 commits intonetworktocode:developfrom
Open
Add in a parser for vendor SummitIG#395nsw3550 wants to merge 3 commits intonetworktocode:developfrom
nsw3550 wants to merge 3 commits intonetworktocode:developfrom
Conversation
nsw3550
requested review from
glennmatthews,
jvanderaa,
pke11y and
scetron
as code owners
Contributor
|
@nsw3550 thank you for the submission: This is a clean submission, thanks! The only thing blocking merge is the missing towncrier changelog fragment. Could you add a one-line file at That should turn the failing CI check green and we can move toward landing this. Apologies for the delay on review. |
Author
|
Added changelog as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added parser for SummitIG along with tests and testdata.
invoke tests
DOCKER - Running command: ruff format --check . container: circuit_maintenance_parser:latest
53 files already formatted
DOCKER - Running command: ruff check --output-format concise . container: circuit_maintenance_parser:latest
All checks passed!
DOCKER - Running command: find . -name "*.py" | grep -vE "tests/unit" | xargs pylint container: circuit_maintenance_parser:latest
Your code has been rated at 10.00/10
...
tests/unit/test_parsers.py::test_parsers[HtmlParserSummitIG-raw_file104-results_file104] PASSED [ 75%]
...
================================================================================== 377 passed in 10.69s ===================================================================================
All tests have passed!